You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that in the coverage for test_isoparser, lines 375, 447 and 449 are not being hit. I can't tell if this means that the tests aren't being run against both bytes and str or if it means that I have unnecessary if conditions in the tests.
If the former, we need to make sure tests are being run against bytes and str. If the latter, we can remove the unnecessary branches.
The parts that are not covered because they are under an xfail can have #pragma: no cover added to them, as can the error handling lines in the test generation part.
The text was updated successfully, but these errors were encountered:
@jramacha Yes, all tests are run with Python 3 and Python 2, but when I say str I mean Python 3's str. In reality it's six.text_type and six.binary_type, or possibly six.text_type (which is unicode in Python 2 and str in Python 3) and bytes, so the tests should do the same thing in Python 2 and 3 anyway.
I've noticed that in the coverage for
test_isoparser
, lines 375, 447 and 449 are not being hit. I can't tell if this means that the tests aren't being run against bothbytes
andstr
or if it means that I have unnecessaryif
conditions in the tests.If the former, we need to make sure tests are being run against
bytes
andstr
. If the latter, we can remove the unnecessary branches.The parts that are not covered because they are under an
xfail
can have#pragma: no cover
added to them, as can the error handling lines in the test generation part.The text was updated successfully, but these errors were encountered: