Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytes/str conversion lines not hit in test_isoparser #776

Closed
pganssle opened this issue Jun 20, 2018 · 2 comments
Closed

bytes/str conversion lines not hit in test_isoparser #776

pganssle opened this issue Jun 20, 2018 · 2 comments

Comments

@pganssle
Copy link
Member

I've noticed that in the coverage for test_isoparser, lines 375, 447 and 449 are not being hit. I can't tell if this means that the tests aren't being run against both bytes and str or if it means that I have unnecessary if conditions in the tests.

If the former, we need to make sure tests are being run against bytes and str. If the latter, we can remove the unnecessary branches.

The parts that are not covered because they are under an xfail can have #pragma: no cover added to them, as can the error handling lines in the test generation part.

@jramacha
Copy link

jramacha commented Oct 24, 2018

@pganssle Since bytes is an alias for str in python 2,( from my python 2.7 interpreter

bytes==str
True)
are these tests supposed to run against bytes and str for python version 3+? Thanks

@pganssle
Copy link
Member Author

pganssle commented Oct 24, 2018

@jramacha Yes, all tests are run with Python 3 and Python 2, but when I say str I mean Python 3's str. In reality it's six.text_type and six.binary_type, or possibly six.text_type (which is unicode in Python 2 and str in Python 3) and bytes, so the tests should do the same thing in Python 2 and 3 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants