You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the method _parse_rfc, lines 1668-1670 of rrule.py (as of commit da9ecd0 , the latest to touch that file as of this writing (not that it changed these particular lines)) read:
Where name is a string. parms here will therefore always be a list of one or more strings. Such a list is never false-y, even if the only entry is the empty string.
It looks to me like that conditional is meant to be checking if the string line looks like ;PARM1;PARM2:MORESTUFF rather than like PROPERTYNAME;PARM1;PARM2:MORESTUFF or PROPERTYNAME:MORESTUFF or etc.
As such, I think the conditional should read, if not parms[0]: instead?
As is, the only way I can see this condition triggering is if name was of some type other than str, such that name.split(';') might return something other than a list of one or more strings.
(If I'm wrong about all this, sorry. I think I'm right though?)
The text was updated successfully, but these errors were encountered:
In the method
_parse_rfc
, lines 1668-1670 of rrule.py (as of commit da9ecd0 , the latest to touch that file as of this writing (not that it changed these particular lines)) read:Where
name
is a string.parms
here will therefore always be a list of one or more strings. Such a list is never false-y, even if the only entry is the empty string.It looks to me like that conditional is meant to be checking if the string
line
looks like;PARM1;PARM2:MORESTUFF
rather than likePROPERTYNAME;PARM1;PARM2:MORESTUFF
orPROPERTYNAME:MORESTUFF
or etc.As such, I think the conditional should read,
if not parms[0]:
instead?As is, the only way I can see this condition triggering is if
name
was of some type other thanstr
, such thatname.split(';')
might return something other than a list of one or more strings.(If I'm wrong about all this, sorry. I think I'm right though?)
The text was updated successfully, but these errors were encountered: