creating unit conversions functions #2433
Conversation
LucasHFS
force-pushed
the
732-unit-conversion-functions
branch
from
3b12e73
to
679a0cd
Compare
|
@LucasHFS As well, could you please add more tests to your test files like |
@tan75 I get it, can I use this logic in similar situations, e.g. minutesToHours & monthsToYears? |
Yes, you can. |
Review hoursToMilliseconds
Review of hoursToMinutes
Review of hoursToSeconds
Review of millisecondsToHours
Review millisecondsToMinutes
Review of millisecondsToSeconds
Review of minuteToHours
Review minutesToMilliseconds
Review minutesToSeconds
Review of monthsToQuarters
Review monthsToYears
quartersToMonths
Review quartersToYears
Review secondsToHours
Review secondsToMilliseconds
Review secondsToMinutes
Review yearsToMonths
Review yearsToQuarters
kossnocorp
force-pushed
the
732-unit-conversion-functions
branch
from
3127586
to
7da59cb
Compare
| assert(millisecondsToMinutes(60000.5) === 1) | ||
| assert(millisecondsToMinutes(0) === 0) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Please take a look at this test file. I want you to rewrite tests in the PR to make them look like this.
Instead of focusing on what test does converts 700 milliseconds to seconds I want you describe behavior and test it. It's enough to have a couple of similar examples that test the same thing:
assert(millisecondsToMinutes(60000) === 1)
assert(millisecondsToMinutes(120000) === 2)Also, when a function does rounding, I want you to add an example for that (please make sure that the first test doesn't check for rounding).
And finally, test border values (float and zero).
|
hi @LucasHFS Hope all is well. Just wondering if you are still working on this PR? |
|
@tan75 Yep, I'll send the requested changes today. |
Added: - Added 18 new conversion functions: - `daysToWeeks` - `hoursToMilliseconds` - `hoursToMinutes` - `hoursToSeconds` - `millisecondsToHours` - `millisecondsToMinutes` - `millisecondsToSeconds` - `minutesToHours` - `minutesToMilliseconds` - `minutesToSeconds` - `monthsToQuarters` - `monthsToYears` - `quartersToMonths` - `quartersToYears` - `secondsToHours` - `secondsToMilliseconds` - `secondsToMinutes` - `weeksToDays` - `yearsToMonths` - `yearsToQuarters`
Attempt to solve #732 . This is my first PR to the lib, any changes needed let me know.