Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options.unit check #2411

Merged
merged 1 commit into from Apr 14, 2021
Merged

Add options.unit check #2411

merged 1 commit into from Apr 14, 2021

Conversation

tan75
Copy link
Contributor

@tan75 tan75 commented Apr 13, 2021

Changes

Now if the distance is 12 month, it returns 1 year.
This change will allow to force a month unit if specified in options.

@tan75 tan75 mentioned this pull request Apr 13, 2021
Closed
@tan75 tan75 requested a review from kossnocorp April 13, 2021 20:52
@tan75 tan75 assigned tan75 and kossnocorp and unassigned tan75 Apr 13, 2021
@tan75 tan75 linked an issue Apr 13, 2021 that may be closed by this pull request
formatDistanceStrict/formatDistanceToNowStrict returns '12 months' rather than '1 year' #2388
Closed
kossnocorp
kossnocorp approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@kossnocorp kossnocorp merged commit c50cb0f into master Apr 14, 2021
@kossnocorp kossnocorp deleted the 2388-month-patch branch April 14, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kossnocorp kossnocorp kossnocorp approved these changes

Assignees

@kossnocorp kossnocorp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

formatDistanceStrict/formatDistanceToNowStrict returns '12 months' rather than '1 year'
2 participants
@tan75 @kossnocorp