Fix warnings in the tests

[kossnocorp]

1. Buffer related:

(node:4314) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

2. os.tmpDir related:

(node:75285) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.

3. find related

find: warning: you have specified the -mindepth option after a non-option argument -type, but options are not positional (-mindepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

[frytyler]

Hey I'll take a look at this and see if I can clean up the warnings.

[frytyler]

Hey @kossnocorp I've been trying to reproduce the issue by running yarn test or yarn test --single-run and I don't see those warnings. I do however see 11 failing tests. Not sure if I'm not seeing the warnings because of the failures though.

Are you able to help me out here? Do I need to run a specific suite?

[frytyler]

@kossnocorp oops, I was on the master branch which I didn't realize is v2. I just switched to v1 started to see the warnings.

But now I have a question. These warnings seem to be related to out of date packages. Will v2 bring those packages up to date? Or should I try to update the ones causing the issues.

[kossnocorp]

@frytyler this issue is related only to master branch. We have the warnings in Node.js 10:

• https://travis-ci.org/date-fns/date-fns/jobs/437138475#L531

• https://travis-ci.org/date-fns/date-fns/jobs/437138475#L565

As far I as I remember I've fixed os.tmpDir updating Karma.

[piotrl]

I analysed log, it seem deprecation warning about Buffer comes from yarn - we're using it in version 1.3.2, and since 1.10.0 the warning is gone.

I tested it on local machine with yarn 1.12.3 and I confirm - there is no deprecation warning anymore.
Therefore updating yarn on CI should do the trick.

[kossnocorp]

@piotrl thank you, I'm on it!