Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider running tests in Node.js #875

Closed
kossnocorp opened this issue Sep 17, 2018 · 0 comments
Closed

Consider running tests in Node.js #875

kossnocorp opened this issue Sep 17, 2018 · 0 comments
Labels
⚙️ Chore

Comments

@kossnocorp
Copy link
Member

Right now we run tests only in headless Chrome. To make sure that date-fns don't break in different Node.js environments, we should consider running tests in Node as well.

For the background, see discussion: #874
@kossnocorp kossnocorp added this to the Not planned milestone Sep 17, 2018
@kossnocorp kossnocorp mentioned this issue Sep 17, 2018
Merged
codinsonn pushed a commit to codinsonn/date-fns that referenced this issue Jun 9, 2019
@kossnocorp @codinsonn
Use Jest to test date-fns in Node.js (date-fns#1192) (closes date-fns…
98674a6 
…#875; closes date-fns#1066)

* Setup Jest
* Update Babel and Power Assert
* Make test karma suite work
* Fix multiple it used instead of describe
* Fix accidentally disabled tests
* Upgrade Sinon
* Add Node.js suite to Travis CI
* Remove node_modules from .flowconfig ignore
* Remove console.log from a test
* Use regexp for exception assertion to make it work in any Node.js
* Disable Sauce Connect because it gives me headaches
codinsonn pushed a commit to codinsonn/date-fns that referenced this issue Jun 10, 2019
@kossnocorp @codinsonn
Use Jest to test date-fns in Node.js (date-fns#1192) (closes date-fns…
4e4d41a 
…#875; closes date-fns#1066)

* Setup Jest
* Update Babel and Power Assert
* Make test karma suite work
* Fix multiple it used instead of describe
* Fix accidentally disabled tests
* Upgrade Sinon
* Add Node.js suite to Travis CI
* Remove node_modules from .flowconfig ignore
* Remove console.log from a test
* Use regexp for exception assertion to make it work in any Node.js
* Disable Sauce Connect because it gives me headaches
elmomalmo pushed a commit to elmomalmo/date-fns that referenced this issue Jul 12, 2019
@kossnocorp @elmomalmo
Use Jest to test date-fns in Node.js (date-fns#1192) (closes date-fns…
eada6f8 
…#875; closes date-fns#1066)

* Setup Jest
* Update Babel and Power Assert
* Make test karma suite work
* Fix multiple it used instead of describe
* Fix accidentally disabled tests
* Upgrade Sinon
* Add Node.js suite to Travis CI
* Remove node_modules from .flowconfig ignore
* Remove console.log from a test
* Use regexp for exception assertion to make it work in any Node.js
* Disable Sauce Connect because it gives me headaches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚙️ Chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kossnocorp