Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatDistance: fixes suffix for AZ #2924

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Conversation

cpapazoglou
Copy link
Contributor

This PR fixes the before, after suffix for AZ locale.

Why
In Azerbaijani the before , after translations were flipped

English Version

if (options.comparison && options.comparison > 0) {
  return 'in ' + result
} else {
  return result + ' ago'
}

Translation
SS 2022-01-19 at 00 05 26

@fturmel
Copy link
Member

fturmel commented Jan 18, 2022

I don't speak the language, but this seems to make sense. Could you run yarn locale-snapshots and commit the updated snapshot.md file?

Curious why the Unicode CLDR has öncə and ərzində as past and future for relative units. Any insights there?
https://unicode-org.github.io/cldr-staging/charts/40/summary/az.html

@cpapazoglou
Copy link
Contributor Author

I don't speak the language, but this seems to make sense. Could you run yarn locale-snapshots and commit the updated snapshot.md file?

Done

Curious why the Unicode CLDR has öncə and ərzində as past and future for relative units. Any insights there? https://unicode-org.github.io/cldr-staging/charts/40/summary/az.html

I am not sure either but my Azerbaijani colleague confirmed that both sonra and əvvəl are valid.

@cpapazoglou
Copy link
Contributor Author

@fturmel can you let me know the process for this to be merged?

@fturmel
Copy link
Member

fturmel commented Jan 24, 2022

One of the maintainers need to approve and merge to master, I'm just a contributor with no write permission on the main branch. It's hard to predict when this might happen, so hang tight.

@cpapazoglou
Copy link
Contributor Author

Hey @leshakoss, I hope you are OK! Just pinging you here in case you missed the notification for merging this. Let me know if there something more I should do.

@leshakoss leshakoss merged commit 345fa6c into date-fns:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants