Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra punctuation in DE medium date #2520

Merged
merged 2 commits into from Jul 23, 2021
Merged

fix: extra punctuation in DE medium date #2520

merged 2 commits into from Jul 23, 2021

Conversation

pmmmwh
Copy link
Contributor

@pmmmwh pmmmwh commented Jun 17, 2021

Since #2365 added punctuation in the abbreviated forms of German months, the . in the medium format to display abbreviated months is no longer needed and if kept would yield Invalid Dates.

Since #2365 added punctuation in the abbreviated forms of German months, the . in the medium format to display abbreviated months is no longer needed and if kept would yield Invalid Dates.
@tan75 tan75 self-assigned this Jun 18, 2021
Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @pmmmwh
thank you for this PR! 👍
Could you please run yarn locale-snapshots and commit the results? This will help the tests to pass.

@tan75 tan75 requested a review from a team June 18, 2021 16:45
@tan75
Copy link
Contributor

tan75 commented Jun 18, 2021

hi @date-fns/i18n-de
could you please have a look and review this PR?

@pmmmwh
Copy link
Contributor Author

pmmmwh commented Jun 22, 2021

Updated locale snapshots! There are still some instances of Invalid Date that I can see but I think they are unrelated to this. I think tests should pass now.

@tan75
Copy link
Contributor

tan75 commented Jun 22, 2021

@saithis
thank you!

Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! 👍

@kossnocorp kossnocorp mentioned this pull request Jul 23, 2021
10 tasks
@kossnocorp kossnocorp merged commit a345b72 into date-fns:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants