Fix - add and subtract when duration has undefined params #2515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've been working with
date-fns
and I saw that theadd
andsubtract
functions fail when they receive aDuration
argument that contains one or more params that were set explicitly asundefined
.Below is an example
This happens, because of this check:
And since
months
is inside theduration
, but is not an integer, the function fails.I've created a PR with a proposed fix and some unit tests to validate that everything is working.
Thanks,
Komyg