Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bosnian locale #2495

Merged
merged 6 commits into from Jul 23, 2021
Merged

Add Bosnian locale #2495

merged 6 commits into from Jul 23, 2021

Conversation

BranislavLazic
Copy link
Member

This PR adds Bosnian locale and resolves this issue #2435.


switch (day) {
case 0:
return "'sledeće nedjelje u' p"
Copy link

@sake92 sake92 May 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also sedmica instead of nedjelja.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thank you!

@tan75 tan75 linked an issue May 28, 2021 that may be closed by this pull request
match: match,
options: {
weekStartsOn: 1 /* Monday */,
firstWeekContainsDate: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @BranislavLazic
Could you please provide a reference that confirms the value of 1 of firstWeekContainsDate?
According to Wikipedia, it is 4 for the majority of European countries.
Do you possibly know a source that we can refer to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you are right. Also, some of them share the same flaw. E.g. sr-Latn (which was my reference locale) or hr.

@BranislavLazic BranislavLazic requested a review from tan75 June 3, 2021 11:45
@tan75
Copy link
Contributor

tan75 commented Jun 3, 2021

@BranislavLazic
could you please re-generate snapshots by running yarn locale-snapshots and commit the results?

Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run yarn locale-snapshots and commit the results.

@tan75 tan75 self-assigned this Jun 3, 2021
Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated! 👍 👍
I will schedule this for our next release given the go-ahead by @kossnocorp

@kossnocorp kossnocorp mentioned this pull request Jul 23, 2021
10 tasks
@kossnocorp kossnocorp merged commit dd71970 into date-fns:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bosnian [bs] locale support
4 participants