New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bosnian locale #2495
Add Bosnian locale #2495
Conversation
|
||
switch (day) { | ||
case 0: | ||
return "'sledeće nedjelje u' p" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that sljedeće
is correct one here. https://bs.wikipedia.org/wiki/Wikipedia:Pravilno-nepravilno_u_bosanskom_jeziku/2018.#S
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also sedmica
instead of nedjelja
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thank you!
src/locale/bs/index.js
Outdated
match: match, | ||
options: { | ||
weekStartsOn: 1 /* Monday */, | ||
firstWeekContainsDate: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @BranislavLazic
Could you please provide a reference that confirms the value of 1 of firstWeekContainsDate
?
According to Wikipedia, it is 4 for the majority of European countries.
Do you possibly know a source that we can refer to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you are right. Also, some of them share the same flaw. E.g. sr-Latn (which was my reference locale) or hr.
@BranislavLazic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run yarn locale-snapshots
and commit the results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much appreciated! 👍 👍
I will schedule this for our next release given the go-ahead by @kossnocorp
This PR adds Bosnian locale and resolves this issue #2435.