Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate formatDistance to TS #2090

Merged
merged 4 commits into from May 5, 2021
Merged

migrate formatDistance to TS #2090

merged 4 commits into from May 5, 2021

Conversation

a-korzun
Copy link
Contributor

@a-korzun a-korzun mentioned this pull request Nov 16, 2020
Merged
tan75
tan75 requested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

@tan75
Copy link
Contributor

tan75 commented Mar 10, 2021

Hello @a-korzun,

could you please resolve conflicts in your code?

tan75
tan75 requested changes Mar 10, 2021
View reviewed changes
src/formatDistance/test.ts Show resolved Hide resolved
@tan75 tan75 self-assigned this Mar 10, 2021
@a-korzun
Copy link
Contributor Author

Hello @a-korzun,

could you please resolve conflicts in your code?

Hi! Don't see any conflicts, may you provide a bit more information about it?
Just updated PR in order to fix migration from power-assert.

@tan75
Copy link
Contributor

tan75 commented Mar 24, 2021

Hello @a-korzun,
could you please resolve conflicts in your code?

Hi! Don't see any conflicts, may you provide a bit more information about it?
Just updated PR in order to fix migration from power-assert.

@a-korzun
It turns out we are using assert now rather than power-assert and you were right when changing it.
Could you please switch it back?
Apologies for the confusion!

@a-korzun
Copy link
Contributor Author

@tan75 Ok, done.

tan75
tan75 approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@tan75 tan75 assigned kossnocorp and unassigned tan75 Mar 26, 2021
kossnocorp
kossnocorp requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Please address my comment about the options type.

src/formatDistance/index.ts Outdated Show resolved Hide resolved
@a-korzun
Copy link
Contributor Author

No problem! Done

@a-korzun @kossnocorp
Update src/formatDistance/index.ts
654d718 
Co-authored-by: Sasha Koss <koss@nocorp.me>
@a-korzun a-korzun requested a review from kossnocorp April 3, 2021 07:41
tan75
tan75 approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kossnocorp kossnocorp merged commit 8cf4074 into date-fns:master May 5, 2021
@a-korzun a-korzun deleted the ts-32 branch May 5, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tan75 tan75 tan75 approved these changes

@kossnocorp kossnocorp Awaiting requested review from kossnocorp

Assignees

@kossnocorp kossnocorp

Labels
TypeScript migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate formatDistance function
3 participants
@a-korzun @tan75 @kossnocorp