Update Macedonian locale. Fixes #1531 #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove |
|
@vlahupetar are you able to review please? |
|
I will review once I get home (in ~8 hours);
So far the only bug i see is in the src/locale/mk/_lib/match/index.js
<https://github.com/date-fns/date-fns/pull/1649/files#diff-c3aabeb88e25d032e18bb2a95e0f650d>
:34
the saturday matcher should be /^с[аб]/ instead of /^с[ъб]/
thanks
Petar
…On Thu, Mar 12, 2020 at 9:41 AM Deniss Kozickis ***@***.***> wrote:
@vlahupetar <https://github.com/vlahupetar> are you able to review please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1649 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMYGS73LH7CNYBOKVYYE43RHDYCLANCNFSM4K7IBQDA>
.
|
dkozickis
approved these changes
Mar 13, 2020
This was referenced Mar 16, 2020
This was referenced Mar 29, 2020
This was referenced Apr 5, 2020
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Macedonian locale for v2 #1531