Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore now-dependent functions #1184

Closed
kossnocorp opened this issue Jun 5, 2019 · 0 comments
Closed

Restore now-dependent functions #1184

kossnocorp opened this issue Jun 5, 2019 · 0 comments
Labels
🎉 Feature
Milestone
v2 beta

Comments

@kossnocorp
Copy link
Member

These functions were removed so we can have "pure" FP. It was done with good intention but caused some users pain. Now I see that we can have both FP and now-dependent functions.

What needs to be done:

  • Restore now-dependent functions.
  • Adjust the FP generation and ignore these functions.
  • Adjust docs to reflect the previous point.

See this gist for the full list of the functions: https://gist.github.com/kitze/b0e72300cee1fb7194e2bd8ccf4091f3
@kossnocorp kossnocorp added this to the v2 beta milestone Jun 5, 2019
@kossnocorp kossnocorp changed the title Get back "now" Restore now-dependent functions Jun 5, 2019
This was referenced Jun 9, 2019
Closed
Merged
elmomalmo pushed a commit to elmomalmo/date-fns that referenced this issue Jul 12, 2019
@kossnocorp @elmomalmo
Restore now-dependent functions (closes date-fns#1184) (date-fns#1197)
e1a44d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 Feature
Projects
None yet
Milestone
v2 beta
Development

No branches or pull requests
1 participant
@kossnocorp