Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useful constants #1076

Merged
merged 4 commits into from Jun 7, 2019
Merged

Conversation

cmatiello
Copy link
Contributor

Implements #609

I wasn't able to run the build script because my file doesn't export a function.
How can I do it?

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kossnocorp
Copy link
Member

I've reworked the PR and also integrated constants into the build system:

  • minTime & maxTime instead of minDate & maxDate as having them as numbers makes more sense.
  • Removed epochDate as it could be represented by simple 0

@kossnocorp kossnocorp merged commit 9255506 into date-fns:master Jun 7, 2019
kossnocorp pushed a commit that referenced this pull request Jun 7, 2019
* Add constants: `minTime`, `maxTime`.
* Integrate constants into build system & docs.
elmomalmo pushed a commit to elmomalmo/date-fns that referenced this pull request Jul 12, 2019
* Add constants: `minTime`, `maxTime`.
* Integrate constants into build system & docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants