From 968432ca0565f4af138c65ee21e134aa9980a2be Mon Sep 17 00:00:00 2001 From: Lari Hotari Date: Mon, 23 Aug 2021 21:15:14 +0300 Subject: [PATCH] [Broker] Handle NPE when full key range isn't covered with active consumers (#11749) (cherry picked from commit 8027ab4e8763486de16d4b2f850b234b70a16b27) --- .../PersistentStickyKeyDispatcherMultipleConsumers.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java index c23b3600e2335..d4d64e25ab831 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java @@ -175,8 +175,12 @@ protected void sendMessagesToConsumers(ReadType readType, List entries) { for (Entry entry : entries) { int stickyKeyHash = getStickyKeyHash(entry); Consumer c = selector.select(stickyKeyHash); - groupedEntries.computeIfAbsent(c, k -> new ArrayList<>()).add(entry); - consumerStickyKeyHashesMap.computeIfAbsent(c, k -> new HashSet<>()).add(stickyKeyHash); + if (c != null) { + groupedEntries.computeIfAbsent(c, k -> new ArrayList<>()).add(entry); + consumerStickyKeyHashesMap.computeIfAbsent(c, k -> new HashSet<>()).add(stickyKeyHash); + } else { + entry.release(); + } } AtomicInteger keyNumbers = new AtomicInteger(groupedEntries.size());