Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Layout/RescueEnsureAlignment cop #133

Closed
roman-dubrovsky opened this issue Nov 19, 2019 · 5 comments
Closed

Setup Layout/RescueEnsureAlignment cop #133

roman-dubrovsky opened this issue Nov 19, 2019 · 5 comments
Assignees
Labels
blocked feature request New feature or request good first issue Easy task, suitable for newcomers to the project library issue issue has been created in rubocop library or just in progress and waiting for approval
Milestone

Comments

@roman-dubrovsky
Copy link
Contributor

Related with the next issue #130

Need to set up the rule for the next cop: Layout/RescueEnsureAlignment

Now It suggests correcting to

  def facebook_util
    return @facebook_util if defined? @facebook_util

    @facebook_util = begin
                       FacebookUtil.new(@account.id)
                     rescue
                       nil
                     end
  end

should be

  def facebook_util
    return @facebook_util if defined? @facebook_util

    @facebook_util = begin
      FacebookUtil.new(@account.id)
    rescue
      nil
    end
  end
@roman-dubrovsky roman-dubrovsky added feature request New feature or request good first issue Easy task, suitable for newcomers to the project labels Nov 19, 2019
@roman-dubrovsky roman-dubrovsky added this to the 0.7.0 milestone Nov 19, 2019
@roman-dubrovsky roman-dubrovsky changed the title Title goes here Setup Layout/RescueEnsureAlignment here Nov 20, 2019
@roman-dubrovsky roman-dubrovsky changed the title Setup Layout/RescueEnsureAlignment here Setup Layout/RescueEnsureAlignment cop Nov 20, 2019
@lazycoder9
Copy link
Contributor

@roman-dubrovsky after a little investigation found that related cops are buggy now (Layout/EndAlignment and Layout/RescueEnsureAlignment). I think we should postpone it until fixes will release

@roman-dubrovsky
Copy link
Contributor Author

@lazycoder9 why is it buggy? can you write your thoughts what is wrong? or just links to issues or PRs?

@lazycoder9
Copy link
Contributor

@roman-dubrovsky Oh, it seems the links in the previous comment were not obvious, but they were links to issue

@nikitasakau
Copy link
Member

This issue still not resolved

@roman-dubrovsky roman-dubrovsky modified the milestones: 0.7.0, 0.8.0 Jan 27, 2020
@roman-dubrovsky roman-dubrovsky added the fixed in new library version the issue has been reported and fixed in library repository but has not been merged or released yet label Feb 5, 2020
@roman-dubrovsky roman-dubrovsky removed the fixed in new library version the issue has been reported and fixed in library repository but has not been merged or released yet label Feb 19, 2020
@roman-dubrovsky roman-dubrovsky modified the milestones: 0.8.0, 0.9.0 Feb 19, 2020
@roman-dubrovsky roman-dubrovsky added the library issue issue has been created in rubocop library or just in progress and waiting for approval label Feb 19, 2020
@roman-dubrovsky roman-dubrovsky modified the milestones: 0.10.0, 0.11.0 Jul 17, 2020
@roman-dubrovsky roman-dubrovsky modified the milestones: 0.11.0, 1.1.0 Nov 7, 2020
@paydaylight
Copy link
Contributor

paydaylight commented Feb 16, 2021

Seems this is fixed in this issue and released in 0.91.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked feature request New feature or request good first issue Easy task, suitable for newcomers to the project library issue issue has been created in rubocop library or just in progress and waiting for approval
Projects
None yet
Development

No branches or pull requests

4 participants