Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify local eslint rules by using overrides in the configuration #9

Open
ezhlobo opened this issue Aug 19, 2019 · 1 comment
Open

Comments

@ezhlobo
Copy link
Member

ezhlobo commented Aug 19, 2019

Seems like we can remove a lot of our conditions in local rules by just . applying those rules for certain files:

https://github.com/eslint/eslint/blob/master/docs/user-guide/configuring.md#disabling-rules-only-for-a-group-of-files

Need to investigate. At least we can completely eliminate ruleCollectionNamedExport.

Thanks @nixololo for that ;).

@ezhlobo
Copy link
Member Author

ezhlobo commented Sep 3, 2019

Seems like we can't apply this. Overrides require relative paths to the config and it forbids using ../, so we can't specify overrides in our config (which is placed deeply in node_modules).

We can track and see where they come to: eslint/eslint#11558

For now I'm leaving this issue opened, but it looks like the eslint won't change that behavior. So likely we can do nothing with overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant