Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: use native async fn in trait syntax #12201

Open
andylokandy opened this issue Jul 25, 2023 · 3 comments
Open

Refactor: use native async fn in trait syntax #12201

andylokandy opened this issue Jul 25, 2023 · 3 comments
Assignees
@ct20000901
Labels
C-refactoring Category: refactor good first issue Category: good first issue

Comments

@andylokandy
Copy link
Collaborator

andylokandy commented Jul 25, 2023 •
edited

Summary

The native async-fn-in-trait has been available in the nightly version for some time now. Perhaps it's time to start replacing async_trait with this native feature.
@andylokandy andylokandy added C-refactoring Category: refactor good first issue Category: good first issue labels Jul 25, 2023
@ct20000901
Copy link
Contributor

I'm genuinely interested in this task, and if it's possible, I would be honored to take on the responsibility of completing it.

@andylokandy
Copy link
Collaborator Author

@ct20000901 Just a reminder, the native async in trait doesn't support dyn object yet.

@ct20000901
Copy link
Contributor

@ct20000901 Just a reminder, the native async in trait doesn't support dyn object yet.

Thank you for the reminder, and I have already discussed this with PsiACE. Currently, the plan is to refactor the parts that only involve static calls to traits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ct20000901 ct20000901

Labels
C-refactoring Category: refactor good first issue Category: good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andylokandy @ct20000901