Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Try using pymssql if the ODBC driver is unavailable #879

Closed
wants to merge 3 commits into from

Conversation

zhiweio
Copy link

@zhiweio zhiweio commented Mar 30, 2024

The data-diff currently uses pyodbc to access MsSQL. However, installing the ODBC driver can be challenging in certain scenarios. Therefore, I added support for pymssql to enable usage even when no ODBC driver is installed.

What do you think about it?

@nolar @sungchun12 Please review this PR, thank you.

leoebfolsom and others added 3 commits March 30, 2024 15:09
* Update README.md

Remove databases that are not planned from README.

* style fixes by ruff

---------

Co-authored-by: leoebfolsom <leoebfolsom@users.noreply.github.com>
@zhiweio
Copy link
Author

zhiweio commented Mar 30, 2024

MsSQL tests from this PR #795

@zhiweio
Copy link
Author

zhiweio commented Mar 30, 2024

Issue mentioned #878

@glebmezh
Copy link
Contributor

Hi @zhiweio,

I'm sorry for the delay in following up on this. Thank you for taking the time to open this PR!

We made a hard decision to sunset the data-diff package and won't provide further development or support.

If that helps at all, we have full support for MySQL diffing in Datafold Cloud.

-Gleb

@glebmezh glebmezh closed this May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants