Windows installation throws error when it tries to run post install hook

[rgembalik]

On windows, when I try to install the plugin it tries to run .sh file (I presume from hooks.install), which throws an error (since windows doesn't natively run sh files, nor there is an install-binary.sh in the release tgz). When I manually download the release and paste it into .helm/plugins, then it looks for .helm\\plugins\\diff/bin/diff which is incorrect since the tgz file contains exe in the main directory.

It all runs well if I download tgz release, paste it manually, create bin folder for it, and throw .exe file in the bin folder.

[Tzrlk]

I get a different error during the post-install:

helm plugin install https://github.com/databus23/helm-diff
No prebuild binary for windows-386.
Failed to install helm-diff
\tFor support, go to https://github.com/databus23/helm-diff.
Error: plugin install hook for "diff" exited with error

(yes, the "\t" appears to have been escaped before printing)

Predictably followed by this when I go to run helm diff help:

helm diff help
Error: exec: "C:\\Users\\tzrlk\\.helm\\plugins\\helm-diff/bin/diff": file does not exist

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[cilerler]

go away stale bot

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[cilerler]

go away stale bot

[eshepelyuk]

The issue stil exists

C:\Users\Evgeny>helm plugin install https://github.com/databus23/helm-diff --version master
Windows Subsystem for Linux has no installed distributions.
Distributions can be installed by visiting the Microsoft Store:
https://aka.ms/wslstore
Error: plugin install hook for "diff" exited with error

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[cilerler]

go away stale bot

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[cilerler]

go away stale bot

[mumoshu]

Hey! Honestly I don't know how I can test this myself because I don't own a windows pc.

But anyway, @Tzrlk's issue and @rgembalik's second issue seems to be caused by this line https://github.com/databus23/helm-diff/blob/master/plugin.yaml#L8 as @rgembalik has described. If we changed it to command: "$HELM_PLUGIN_DIR\bin\diff" it would indeed work for Windows, but not on *nix.

I'm now wondering how helm itself is supposed to support plugins on Windows? 🤔

[mumoshu]

So the community direction seems like we should instruct users to use it on WSL.

helm/helm-2to3#118

[mumoshu]

The upstream issue to add support for plugin installation on Windows is helm/helm#7117

[Tzrlk]

Yeah, I love how helm seems to have completely different plugin storage mechanisms for each OS.

…

On Mon., 17 Aug. 2020, 11:45 am Yusuke Kuoka, ***@***.***> wrote: Hey! Honestly I don't know how I can test this myself because I don't own a windows pc. But anyway, @Tzrlk <https://github.com/Tzrlk>'s issue and @rgembalik <https://github.com/rgembalik>'s second issue seems to be caused by this line https://github.com/databus23/helm-diff/blob/master/plugin.yaml#L8 as @rgembalik <https://github.com/rgembalik> has described. If we changed it to command: "$HELM_PLUGIN_DIR\bin\diff" it would indeed work for Windows, but not on *nix. I'm now wondering how helm itself is supposed to support plugins on Windows? 🤔 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#55 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABJNQ6FWAEC7CXSRWMIG6DSBBVRLANCNFSM4FCL3L6Q> .

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[cilerler]

go away stale bot

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[agastyasilvina]

go away stale