Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distributed hangs on Windows with Python 3.13 #8641

Closed
vstinner opened this issue May 7, 2024 · 1 comment · Fixed by #8642
Closed

distributed hangs on Windows with Python 3.13 #8641

vstinner opened this issue May 7, 2024 · 1 comment · Fixed by #8642

Comments

@vstinner
Copy link
Contributor

vstinner commented May 7, 2024

Describe the issue:

Minimal Complete Verifiable Example:

from dask.distributed import Client, Worker, Scheduler, wait
import pyperf

def inc(x):
    return x + 1

async def benchmark():
    async with Scheduler() as scheduler:
        async with Worker(scheduler.address):
            async with Client(scheduler.address, asynchronous=True) as client:
                futures = client.map(inc, range(100))
                for _ in range(10):
                    futures = client.map(inc, futures)
                await wait(futures)

if __name__ == "__main__":
    runner = pyperf.Runner()
    runner.metadata['description'] = "Benchmark dask"
    runner.bench_async_func('dask', benchmark)

Anything else we need to know?:

Environment:

  • Dask version: 2024.5.0
  • Python version: 3.13 (main branch, future 3.13 beta 1)
  • Operating System: Windows 11
  • Install method (conda, pip, source): pip
vstinner added a commit to vstinner/distributed that referenced this issue May 7, 2024
Closes dask#8641.

_WindowsTime is no longer needed on Python 3.13. On Python 3.13 on
Windows, time.time() now uses GetSystemTimePreciseAsFileTime(), and
time.monotonic() now uses QueryPerformanceCounter().
vstinner added a commit to vstinner/distributed that referenced this issue May 7, 2024
Closes dask#8641.

_WindowsTime is no longer needed on Windows with Python 3.13. On
Windows, Python 3.13 now uses GetSystemTimePreciseAsFileTime() for
time.time() and QueryPerformanceCounter() for time.monotonic().

* python/cpython#116781
* python/cpython#116822
@vstinner
Copy link
Contributor Author

vstinner commented May 7, 2024

I proposed the pull request #8642 to fix the issue.

fjetter pushed a commit that referenced this issue May 8, 2024
Closes #8641.

_WindowsTime is no longer needed on Windows with Python 3.13. On
Windows, Python 3.13 now uses GetSystemTimePreciseAsFileTime() for
time.time() and QueryPerformanceCounter() for time.monotonic().

* python/cpython#116781
* python/cpython#116822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant