Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest-xdist is not being ignored in code samples #8602

Open
crusaderky opened this issue Mar 28, 2024 · 0 comments
Open

pytest-xdist is not being ignored in code samples #8602

crusaderky opened this issue Mar 28, 2024 · 0 comments
Labels
bug Something is broken p3 Affects a small number of users or is largely cosmetic

Comments

@crusaderky
Copy link
Collaborator

The xdist module has been in the code capture ignorelist since #8290.
However, this is from the most recent coiled/benchmarks run:

Span test_query_1 in /home/runner/miniconda3/envs/test/lib/python3.12/site-packages/xdist/remote.py
    def run_one_test(self):
        self.item_index = self.nextitem_index
        self.nextitem_index = self._get_next_item_index()

        items = self.session.items
        item = items[self.item_index]
        if self.nextitem_index is self.SHUTDOWN_MARK:
            nextitem = None
        else:
            nextitem = items[self.nextitem_index]

        worker_title("[pytest-xdist running] %s" % item.nodeid)

        start = time.time()
        self.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
        duration = time.time() - start

        worker_title("[pytest-xdist idle]")

        self.sendevent(
            "runtest_protocol_complete", item_index=self.item_index, duration=duration
        )
Span test_query_1 in /home/runner/work/benchmarks/benchmarks/tests/tpch/test_dask.py
@pytest.mark.shuffle_p2p
def test_query_1(client, dataset_path, fs, scale):
    dask_queries.query_1(dataset_path, fs, scale).compute()
@crusaderky crusaderky added bug Something is broken p3 Affects a small number of users or is largely cosmetic labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken p3 Affects a small number of users or is largely cosmetic
Projects
None yet
Development

No branches or pull requests

1 participant