Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop yaml support in cluster_dump #8541

Closed
hendrikmakait opened this issue Feb 28, 2024 · 4 comments
Closed

Drop yaml support in cluster_dump #8541

hendrikmakait opened this issue Feb 28, 2024 · 4 comments
Labels
deprecation Something is being removed diagnostics

Comments

@hendrikmakait
Copy link
Member

Our cluster_dump functionality is currently broken wrt. key roundtrips (#8540), which we need to fix. Since I do not see the added value in supporting both msgpack and yaml, I'm inclined to limit the fix for roundtripping to msgpack and drop support for yaml without a deprecation cycle. (It's mostly broken anyways.) Note that we will still have DumpArtefact.to_yamls in case users want to create human-readable files. Also, msgpack is already a required dependency.

@fjetter
Copy link
Member

fjetter commented Feb 29, 2024

Actually, msgpack was added only later because the dumps grew too large. the benefit of yaml is that it is human readable. I often analyzed those dumps by grepping/searching and reading the files.
I'm fine with dropping support for the dump to be written directly to yaml but there is also DumpArtefact.to_yamls which probably has the same problem

@hendrikmakait
Copy link
Member Author

I'm fine with dropping support for the dump to be written directly to yaml but there is also DumpArtefact.to_yamls which probably has the same problem

It will. Since we won't have to be able to roundtrip, I think we can get away with a simpler implementation here, i.e., simply stringifying keys. You could then grep for the stringified key in the yaml files.

@crusaderky
Copy link
Collaborator

+1. I like human-readable but converting from msgpack when needed is 3 lines

@hendrikmakait
Copy link
Member Author

Closing this as not planned. In #8540, we decided against touching cluster dumps at all for now.

@hendrikmakait hendrikmakait closed this as not planned Won't fix, can't repro, duplicate, stale Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Something is being removed diagnostics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants