Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guarantee ordering between plugin hooks #8486

Open
hendrikmakait opened this issue Jan 31, 2024 · 0 comments
Open

Guarantee ordering between plugin hooks #8486

hendrikmakait opened this issue Jan 31, 2024 · 0 comments
Labels
enhancement Improve existing functionality or make things work better

Comments

@hendrikmakait
Copy link
Member

Problem

Currently, there are no ordering guarantees between plugin hooks. In particular, start/setup and close/teardown get executed concurrently for all plugins. This creates problems in some cases (e.g., #8485) and makes it generally harder to reason about things.

Proposed Solution

It would be nice if we could guarantee ordering between the individual plugins. This probably means that we choose their registration order to ensure that the ordering is always the same, e.g. for existing and new workers.

Notes

There are some caveats to this, like non-ordered RPC calls (#7480), that we need to consider.

@hendrikmakait hendrikmakait added the enhancement Improve existing functionality or make things work better label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or make things work better
Projects
None yet
Development

No branches or pull requests

1 participant