Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker.close() leaves RPC channels dangling #6409

Open
crusaderky opened this issue May 21, 2022 · 0 comments
Open

Worker.close() leaves RPC channels dangling #6409

crusaderky opened this issue May 21, 2022 · 0 comments

Comments

@crusaderky
Copy link
Collaborator

Follow-up from #6371 and #6385.
CC @gjoseph92

test_deadlock_cancelled_after_inflight_before_gather_from_worker removes a worker while another worker has a task in flight from it.

The test calls

await s.remove_worker(
address=x.address, safe=True, close=close_worker, stimulus_id="test"
)

which in turn calls
if close:
with suppress(AttributeError, CommClosedError):
self.stream_comms[address].send({"op": "close"})

which in turrn calls
await self.rpc.close()

Expected result

The RPC channel is explicitly shut down. The waiting gather_dep call on the other worker raises OSError within milliseconds.

Actual result

The RPC channel is left dangling until the TCP timeout kicks in (5s by default; in the test it's been shortened to 0.5s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant