Deadlock - Ensure resumed flight tasks are still fetched #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
force-pushed
the
deadlock_resumed_flight
branch
4 times, most recently
from
c7e6e8b
to
de1bcd9
Compare
|
FWIW the power user who originally reported this issue tried this PR and it looks promising to not deadlock any longer. |
crusaderky
reviewed
Oct 21, 2021
fjetter
force-pushed
the
deadlock_resumed_flight
branch
from
74abd60
to
4138c3d
Compare
|
I see couldn't reproduce, yet |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another deadlock introduced by #5160. In a nutshell, all tasks entering gather_deps must be handled / transitioned out of flight even though we're not trying to fetch all of the keys.
A second problem popping up is that the
TaskState.donewas not properly (re-)set causing dependencies to be fetched to be transitioned falsely.This also closes #5406
Follow up PR to establish an enum as the worker task state name: #5444