Include addresses in closed comm repr

[jrbourbeau]

This PR updates our comm reprs to include local and remote address after the comm has been closed (this information is already included when the comm is running). This means the repr for closed comm will look like

<TLS (closed)  local=tls://... remote=tls://...>

instead of

<closed TLS>

which will help aid debugging (xref #5202)

cc @mrocklin @fjetter

[fjetter]

I'm not entirely sure if this helps. We often raise a CommClosedError without context. Either way, I think this is a good idea

[fjetter]

See also #5209

[jrbourbeau]

Thanks for reviewing @fjetter! My thinking was that since we use the comm repr in convert_stream_closed_error

distributed/distributed/comm/tcp.py

Lines 116 to 128 in e34b3e8

	def convert_stream_closed_error(obj, exc):
	"""
	Re-raise StreamClosedError as CommClosedError.
	"""
	if exc.real_error is not None:
	# The stream was closed because of an underlying OS error
	exc = exc.real_error
	if ssl and isinstance(exc, ssl.SSLError):
	if "UNKNOWN_CA" in exc.reason:
	raise FatalCommClosedError(f"in {obj}: {exc.__class__.__name__}: {exc}")
	raise CommClosedError(f"in {obj}: {exc.__class__.__name__}: {exc}") from exc
	else:
	raise CommClosedError(f"in {obj}: {exc}") from exc

it will help in those situations (which I've been running into recently). Totally agree #5209 is a more thorough solution 👍