Fix test_process_executor_kills_process flakyness #5183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
crusaderky
commented
Aug 10, 2021
| @@ -2229,7 +2229,7 @@ def _transition(self, key, finish: str, *args, **kwargs): | |||
| self._transition_counter += 1 | |||
| recommendations, client_msgs, worker_msgs = a | |||
| elif "released" not in start_finish: | |||
| assert not args and not kwargs | |||
| assert not args and not kwargs, (args, kwargs) | |||
There was a problem hiding this comment.
|
Ready for final review and merge |
fjetter
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_process_executor_kills_process has started chain-failing on ubuntu 3.7/3.8/3.9 and on macosx 3.7 (only).
Possibly it's not failing on macosx 3.8/3.9 because the scheduler is not cythonized and that's enough to slow everything down to let the SIGTERM take effect?
This PR changes SIGTERM to SIGKILL which should be instantaneous at all times.
Also address a couple other flaky tests.