Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text exceptions to the Scheduler #5148

Merged
merged 5 commits into from
Aug 10, 2021
Merged

Conversation

mrocklin
Copy link
Member

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to worry about size? This stores the traceback in plain txt but we usually truncate exception messages. I guess we truncate exceptions for readability but there is no harm in actually submitting the entire traceback, is there?

@mrocklin
Copy link
Member Author

mrocklin commented Aug 2, 2021

Perhaps we should add a [-10000:] to the traceback text?

@fjetter
Copy link
Member

fjetter commented Aug 2, 2021

Perhaps we should add a [-10000:] to the traceback text?

Fine by me but I'm also fine with doing nothing if it is not clear why we're doing it. Whether or not we need to truncate depends on the usage. For instance, logs will need to be truncated since too large message can break certain loggers.
I just wanted to ask in case I was missing anything

@mrocklin
Copy link
Member Author

mrocklin commented Aug 2, 2021 via email

@mrocklin mrocklin merged commit a742de4 into dask:main Aug 10, 2021
@mrocklin mrocklin deleted the string-exceptions branch August 10, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store text error messages and tracebacks in scheduler
2 participants