New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.11 #9708
Conversation
c9fa962
to
5246405
Compare
5246405
to
f8d22c9
Compare
getting a segfault here: https://github.com/dask/dask/actions/runs/3638328422/jobs/6140402545#step:7:11195 looks like pandas-dev/pandas#50105 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice detective work @graingert. Sounds like we can safely xfail
the unhappy hdf-related tests on Python 3.11
we can't xfail them as they segfault - will have to skip them for now |
👍 |
depends on dask/distributed#7249 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restarting failed builds as it looks like the linux Python 3.11 build stalled for some reason
Co-authored-by: crusaderky <crusaderky@gmail.com>
Co-authored-by: crusaderky <crusaderky@gmail.com>
Should this still be a draft? |
Hmm pyarrow isn't working due to
|
Would just pin to Arrow 9. Likely it will require work to upgrade to a newer version |
Isn't it easier to comment it out again for the time being? numba is also unavailable anyway and they have a history of being several months late every time there's a new major python version. |
There should be a Python 3.11 package for Arrow 9 already It is just Arrow 10 came out somewhat recently and there are some fairly significant changes in it that should improve things overall. Just will take time to fully adapt to. So that's what we are seeing here |
@graingert commented in a previous version of the PR that pyarrow 10 is necessary for python 3.11 |
That doesn't sound right. Arrow 9 was definitely built for Python 3.11 (for example). If that doesn't work, would be very interested to know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, looks like the issue was due to the libprotobuf
pin. That's only needed for the pyarrow
-nightly build and has since been moved to a different file anyways. After removing the libprotobuf
pin, I was able to get a solved Python 3.11 environment locally on my mac. Let's see if it solves in CI.
Looks like that did the trick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Linux 3.11 build stalled for some reason, so I just retriggered CI to see if the stall happens consistently or not. If it doesn't, I think this is good to go
I'll be glad to see this get in. Thank you everyone who helped here. I'm excited for Python 3.11. |
Okay, looks like the hanging Linux Python 3.11 build passed (🎉 ) but we're seeing |
Alright, looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @graingert @crusaderky @jakirkham!
pre-commit run --all-files