New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test_dataframe_aggregations_multilevel
#9701
Conversation
Update: Seems like this may fix the problem - Just added a comment, and re-running CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
I think so, but not completely sure. Honestly not sure what else may be causing the problem. |
I see a similar thing happening here dask/dask/dataframe/groupby.py Lines 640 to 646 in 49b516b
I'll suggest we update there too and then merge this PR in. The change here seems consistent with fixing #8795 and also straightforward. We can always reopen #8795 if we see the flaky test failure again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rjzamora!
test_dataframe_aggregations_multilevel
I'm struggling to reproduce the recent groupby CI failures locally. However, it seems possible that these errors could be the result of
_mul_cols
being passed an empty group withinapply
. This PR adds a possible fix if this happens to be the root cause.