Method changed to support duplicate column cum-functions #9685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? Admins can comment |
|
ok to test |
|
Does anyone know if this failing on Ubuntu with python3.10 is an issue anywhere else or specific to this pull request? I'd have assumed that an os/python version problem would be caused by a dependency or something (rather than just switching out dictionary for list comprehension)? Seen that this pull request which touches a completely different part of the codebase seems to have the same issue, but others seem to have all passing tests? |
|
#9701 |
rjzamora
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesHello 👋 Thanks for all the work you do maintaining dask! I've picked up 9122 as a first time issue- the implementation is literally exactly as @TomAugspurger suggests in the thread, with the addition that I've added some checks for duplicate column names within test_dataframe alongside other existing cum-function tests.
Potentially worth bearing in mind the additional test for this pull request: #9422 - obviously, explicitly forbidding duplicate column names will cause a test that these tests would need to be ammended.