Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ga-yaml-parser step in gpuCI updating workflow #9675

Merged
merged 2 commits into from Nov 18, 2022

Conversation

charlesbluca
Copy link
Member

Looks like the auto-bump of ga-yaml-parser in #9553 changed the behavior of the action, making it so we haven't been running the gpuCI updating workflow in a while; this PR makes modifications that should unblock it.

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

@charlesbluca charlesbluca marked this pull request as ready for review November 18, 2022 16:07
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing @charlesbluca!

Unrelated to the changes here, but I see we're getting the following failure in gpuCI:

FAILED dask/dataframe/io/tests/test_io.py::test_from_dict_backends[cudf] - TypeError: from_dict() got an unexpected keyword argument 'constructor'

cc @rjzamora @galipremsagar for visibility. We're planning to release dask soon. Is this failure problematic for that?

EDIT: my guess is "no" as it looks like this is an issue on the cudf side of things

@jrbourbeau jrbourbeau merged commit 5a52c83 into dask:main Nov 18, 2022
@charlesbluca
Copy link
Member Author

Yeah, I recently noticed that the Dask gpuCI images hadn't been rebuilt in a while and just resolved the failures in rapidsai/dask-build-environment#54, so we might see some failures crop up in Dask/Distributed that weren't caught over the past few days

@jrbourbeau
Copy link
Member

Are both the dask and distributed main branches now in a state where they're using rebuilt images?

@charlesbluca
Copy link
Member Author

Yeah, we may see some failures crop on Distributed as well (am currently opening up a PR like this for distributed so can take a look there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants