Enable column projection for groupby slicing #9667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
referenced
this pull request
in EthanRosenthal/medium-data-bakeoff
Nov 16, 2022
3 tasks
jrbourbeau
reviewed
Nov 21, 2022
dask/dataframe/groupby.py
Outdated
|
|
||
| # Check if we can project columns | ||
| projection = None | ||
| if isinstance(self._slice, (str, list)): |
There was a problem hiding this comment.
What other types are valid here?
EDIT: Aside from None, given that this is an optional kwarg
There was a problem hiding this comment.
The slice= kwarg is set by the key in a DataFrameGroupBy.__getitem__ call. Therefore, I suppose it can be anything representing a column selection. I opted to keep the projection simple here for now, but we certainly can generalize this.
There was a problem hiding this comment.
Hopefully the latest code supports all (reasonable) self._slice types (numpy scalar, str, list, tuple, index-like, and series-like)
Co-authored-by: Florian Jetter <fjetter@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #9442, dask will insert a
getitemoperation to enable column projection for operations likegroupby().agg. As pointed out in this external commit, dask does not yet capture a simplegroupby().[<slice>]case.This PR simply adds a
getitemoperation for groupby slicing.pre-commit run --all-files