Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard docs for queuing #9660

Merged
merged 7 commits into from Nov 15, 2022

Conversation

gjoseph92
Copy link
Collaborator

@gjoseph92 gjoseph92 commented Nov 14, 2022

Closes dask/distributed#7306.

Also some driveby fixes of typos/small inaccuracies in the docs (not exhaustive).

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions github-actions bot added the documentation Improve or add to documentation label Nov 14, 2022
@gjoseph92
Copy link
Collaborator Author

Copy link
Member

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, we are seeing multiple failures but they are unrelated to this PR.
The only doubt I have and not sure what's going on is with the linting check

@gjoseph92
Copy link
Collaborator Author

WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f26ec47bbe0>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /packages/b2/6c/9ccb5213a3d9fd3f8c0fd69d207951901eaef86b7a1a69bcc478364d3072/pre_commit-2.20.0-py2.py3-none-any.whl
  WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f26ec47beb0>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /packages/b2/6c/9ccb5213a3d9fd3f8c0fd69d207951901eaef86b7a1a69bcc478364d3072/pre_commit-2.20.0-py2.py3-none-any.whl
  WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f26ec47bf70>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /packages/b2/6c/9ccb5213a3d9fd3f8c0fd69d207951901eaef86b7a1a69bcc478364d3072/pre_commit-2.20.0-py2.py3-none-any.whl
  WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f26ec4a4040>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /packages/b2/6c/9ccb5213a3d9fd3f8c0fd69d207951901eaef86b7a1a69bcc478364d3072/pre_commit-2.20.0-py2.py3-none-any.whl
  WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f[26](https://github.com/dask/dask/actions/runs/3465838377/jobs/5789036313#step:4:28)ec4a42b0>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /packages/b2/6c/9ccb5213a3d9fd3f8c0fd69d207951901eaef86b7a1a69bcc478364d3072/pre_commit-2.20.0-py2.py3-none-any.whl
ERROR: Could not install packages due to an OSError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Max retries exceeded with url: /packages/b2/6c/9ccb5213a3d9fd3f8c0fd69d207951901eaef86b7a1a69bcc478364d3072/pre_commit-2.20.0-py2.py3-none-any.whl (Caused by NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f26ec4a4460>: Failed to establish a new connection: [Errno 101] Network is unreachable'))

for linting: some transient pip stuff setting up pre-commit

@jrbourbeau
Copy link
Member

Yep, looks like a connection blip -- restarting that CI build

@gjoseph92
Copy link
Collaborator Author

Looks like linting passed, thanks @jrbourbeau

@ncclementi
Copy link
Member

@gjoseph92 Thanks for this, will merge this in!

@ncclementi ncclementi merged commit 7990fff into dask:main Nov 15, 2022
@gjoseph92 gjoseph92 deleted the dashboard-queuing-docs branch November 15, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improve or add to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note dashboard changes for queuing in docs
3 participants