New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for fastparquet
evolution
#9650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @martindurant
@rjzamora : a quick and simple one, if you have a moment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment fix. Otherwise, LGTM
Co-authored-by: Richard (Rick) Zamora <rzamora217@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martindurant. I think we want to trigger an upstream CI build by including a commit with test-upstream
in it so we can make sure fastparquet_version > parse_version("0.8.3")
is True
(note you'll also want to merge main
as there were some changes to fix the upstream
build that were just merged)
There is no release of fastparquet yet, since dask/fastparquet#818 is waiting on this PR |
The upstream build will install |
No, I didn't even merge it; but I will now, just to ease the impasse :). |
done |
dask/array/tests/test_stats.py::test_two[ttest_1samp-kwargs2] is nothing to do with this PR |
fastparquet
evolution
pre-commit run --all-files
Makes dask/fastparquet#818 pass