Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import dask as d from docstrings #9644

Merged
merged 1 commit into from Nov 10, 2022
Merged

Conversation

mrocklin
Copy link
Member

This seems strange and is not a recommended import name

rjzamora
rjzamora previously approved these changes Nov 10, 2022
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrocklin !

>>> import dask as d
>>> import dask
Copy link
Member

@rjzamora rjzamora Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is another >>> d.compute(a, b) line below that needs to change to >>> dask.compute(a, b)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks @rjzamora

@rjzamora rjzamora dismissed their stale review November 10, 2022 15:07

One more d -> dask change left

This seems strange and is not a recommended import name
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpuci failures are unrelated.

@jrbourbeau jrbourbeau changed the title Remove "import dask as d" from docstrings Remove import dask as d from docstrings Nov 10, 2022
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrocklin

@jrbourbeau jrbourbeau merged commit 90eec29 into dask:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants