Resolve importlib-related failures in upstream CI
#9604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Thanks @charlesbluca! This is definitely a weird one, but I see value in getting our upstream CI job passing and this change doesn't seem unreasonable.
This was referenced Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, importing
importlib.metadatawas causing failures when running through the entire test suite withUPSTREAM_DEV=1(xref #9204 (comment)).It was difficult to track down what tests in particular caused this issue, so opted to switch to
from importlib import metadata, which still seems to work.cc @jrbourbeau
pre-commit run --all-files