Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve upstream CI report #9603

Merged
merged 6 commits into from Oct 27, 2022
Merged

Conversation

jrbourbeau
Copy link
Member

xarray has a nice xarray-contrib/issue-from-pytest-log GitHub action for opening / updating an issue when there's a CI failure. This action fully covers all the existing functionality of our current report job in the upstream build but has a couple of additional benefits:

  1. We get a list of failing tests / exceptions directly in the issue that's opened (see this issue which was opened up by this PR as an example)
  2. We no longer need maintain GitHub script code. This can be maintained by xarray-contrib/issue-from-pytest-log

cc @charlesbluca for thoughts

Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrbourbeau! Just one question

.github/workflows/upstream.yml Outdated Show resolved Hide resolved
Co-authored-by: Charles Blackmon-Luca <20627856+charlesbluca@users.noreply.github.com>
@jrbourbeau
Copy link
Member Author

Thanks @charlesbluca! Let's give this a try on main

@jrbourbeau jrbourbeau merged commit 97c22be into dask:main Oct 27, 2022
@jrbourbeau jrbourbeau deleted the update-upstream-ci branch October 27, 2022 19:53
@jrbourbeau
Copy link
Member Author

Note that #9204 was updated and now has tests and exceptions listed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants