Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nightly recipe with CLI entrypoint #9600

Merged
merged 1 commit into from Oct 26, 2022
Merged

Conversation

charlesbluca
Copy link
Member

Following up on recent work around the CLI (xref conda-forge/dask-core-feedstock#146), this PR adds the CLI entrypoint to the nightly recipe.

cc @jakirkham

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files


requirements:
host:
- python >=3.8
- pip
- setuptools
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the CLI changes, but noticed that setuptools got dropped as a host dependency from the conda-forge recipe

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is a dependency of pip. So always gets pulled in

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Charles! 🙏

@jakirkham
Copy link
Member

Going to go ahead and merge so we can fix this issue, but we can follow up on anything else as needed

@jakirkham jakirkham merged commit 3ed78ec into dask:main Oct 26, 2022
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants