New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataFrame
and Series
median
method
#9483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-r-rose
reviewed
Sep 12, 2022
7 tasks
jrbourbeau
changed the title
[WIP] Add
Add Sep 13, 2022
DataFrame.median
methodDataFrame.median
method
ian-r-rose
reviewed
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, otherwise this looks good to me
ian-r-rose
approved these changes
Sep 13, 2022
Test failure is a known flaky one #8816 |
jrbourbeau
changed the title
Add
Add Sep 13, 2022
DataFrame.median
methodDataFrame
and Series
median
method
Thanks for reviewing @ian-r-rose! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new
median
andmedian_approximate
methods todask.dataframe
.Previously there was hesitation around using approximate algorithms in a
DataFrame.median
method, which could lead to confusion for users who are expectingdask
andpandas
to always return the same result. This PR proposes we usemedian
in cases where we can provide an exact median calculation (i.e. whenaxis=1
or when there's only a single partition in theDataFrame
/Series
). Otherwise, we raise an informative error directing users tomedian_approximate
and (internally) use the existing approximatequantiles
implementation.Closes #4362, supersedes #3819
TODO:
dd.Series
Add median to groupby aggregationsTo reduce the scope of this PR, let's handle this in as a follow-up