Fix overlap so that set_index doesn't drop rows
#9423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've merged main to fix the |
|
I am pretty confident of this change, so I will plan to merge this week unless there are comments. |
ncclementi
reviewed
Sep 12, 2022
dask/dataframe/tests/test_shuffle.py
Outdated
| @@ -1182,6 +1182,17 @@ def test_set_index_overlap_2(): | |||
| assert ddf2.npartitions == 8 | |||
|
|
|||
|
|
|||
| def test_set_index_overlap_3(): | |||
There was a problem hiding this comment.
I see that we have test_set_index_overlap and then _2 and _3. I thought the only thing changing was the number of partitions but it seems it's not just that.
Would it be better to have either a comment/docstring to these tests that explains better what each test is accomplishing?
There was a problem hiding this comment.
yeah it's a lazy name, I did link out to the issue that has the full context. But I'm happy to change the name
jsignell
commented
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddf.set_indexwithsorted=Truedrops rows #9339pre-commit run --all-files