Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing append in delayed best practices example #9202

Merged
merged 1 commit into from Jun 21, 2022

Conversation

beduncs
Copy link
Contributor

@beduncs beduncs commented Jun 21, 2022

Updated code block in delayed best practices docs

  • added appending result to the results list before return in Break up computations into many pieces Do
  • added appending result to the results list before return in Break up computations into many pieces Don't

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions github-actions bot added the documentation Improve or add to documentation label Jun 21, 2022
@jrbourbeau jrbourbeau changed the title docs: added missing append in delayed-best-practices example code Add missing append in delayed best practices example Jun 21, 2022
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benjaminhduncan -- this is in

Also, I noticed this is your first code contribution to this repository. Welcome!

@jrbourbeau jrbourbeau merged commit 0820983 into dask:main Jun 21, 2022
@beduncs beduncs deleted the fix-delayed-best-practices-docs branch June 22, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improve or add to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants