Remove chest
#8279
Merged
Remove chest
#8279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
commented
Oct 20, 2021
Comment on lines
-21
to
-25
| try: | ||
| from chest import Chest as Cache | ||
| except ImportError: | ||
| Cache = dict | ||
|
|
There was a problem hiding this comment.
Cache isn't used anymore
Comment on lines
-277
to
-283
| if DEBUG: | ||
| from chest.core import nbytes | ||
|
|
||
| print( | ||
| "Key: %s\tDep: %s\t NBytes: %.2f\t Release" | ||
| % (key, dep, sum(map(nbytes, state["cache"].values()) / 1e6)) | ||
| ) |
There was a problem hiding this comment.
I don't see this DEBUG flag being used anywhere else. It was probably useful at one point, but I'm fine removing this conditional print
|
Thanks for reviewing @jsignell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes several references to the
chestpackage which are outdated and no longer used todayxref #8278
cc @jsignell