Update tmpdir and tmpfile context manager docstrings
#8270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
Oct 18, 2021
There was a problem hiding this comment.
Thanks for putting this together @mesejo! I left a few small suggestions, but overall this looks good
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
mesejo
force-pushed
the
update-tmpdir-and-tmpfile-context-manager-docstrings
branch
from
9d4406a
to
dcc79a0
Compare
|
@jrbourbeau Thanks for reviewing! I agree with your suggestions and believe now it looks better. |
jrbourbeau
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Thanks @mesejo. This looks great -- will merge after CI finishes
jrbourbeau
changed the title
tmpdir and tmpfile context manager docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmpdirandtmpfilecontext manager docstrings #7800pre-commit run --all-files