Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement check_lengths #865

Open
TomAugspurger opened this issue Oct 16, 2021 · 2 comments · May be fixed by #900
Open

Implement check_lengths #865

TomAugspurger opened this issue Oct 16, 2021 · 2 comments · May be fixed by #900

Comments

@TomAugspurger
Copy link
Member

TomAugspurger commented Oct 16, 2021 •
edited

https://github.com/dask/dask-ml/pull/863/files#diff-970a9a902963a060977ac1912b5a86a5177cebfd468517967f63335bb6d024eaR435-R437 added an empty check_consistent_lengths. We should implement a real one.

Unlike scikit-learn, we don't actually want to check the lengths when constructing the graphs. But we do want to check things like that the number of chunks match, that the chunk shapes match if present, divisions, etc.
@TomAugspurger TomAugspurger changed the title Implement check_lenghts Implement check_lengths Oct 16, 2021
@freddyaboulton
Copy link

@TomAugspurger Isn't that logic already implemented in check_matching_blocks ?

@TomAugspurger
Copy link
Member Author

Yep, that might just do the trick.

@freddyaboulton freddyaboulton linked a pull request Jan 18, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement check_consistent_length freddyaboulton/dask-ml
2 participants
@TomAugspurger @freddyaboulton