Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to skip centering in PCA #734

Open
eric-czech opened this issue Sep 3, 2020 · 1 comment · May be fixed by #808
Open

Flag to skip centering in PCA #734

eric-czech opened this issue Sep 3, 2020 · 1 comment · May be fixed by #808

Comments

@eric-czech
Copy link
Contributor

Hey @TomAugspurger, how opposed would you be to introducing small deviations from the scikit-learn interface to PCA like adding a flag in dask-ml.PCA to avoid requiring this centering?

self.mean_ = X.mean(0)
X -= self.mean_

That would certainly be a bad default, but if I know that is going to happen downstream from a scaling operation in a pipeline that already does the centering, I would like to have the option to avoid the extra operation. Is that reasonable or are you trying maintain something closer to perfect consistency?

@TomAugspurger
Copy link
Member

Seems reasonable to me!

hristog added a commit to hristog/dask-ml that referenced this issue Mar 20, 2021
hristog added a commit to hristog/dask-ml that referenced this issue Mar 20, 2021
@hristog hristog linked a pull request Mar 20, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants