Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other protocols #818

Open
BitTheByte opened this issue Sep 16, 2023 · 3 comments
Open

Support for other protocols #818

BitTheByte opened this issue Sep 16, 2023 · 3 comments

Comments

@BitTheByte
Copy link

Currently, the operator has a hardcoded TCP protocol

{
"name": "DASK_SCHEDULER_ADDRESS",
"value": f"tcp://{cluster_name}-scheduler.{namespace}.svc.cluster.local:8786",
},
]

@jacobtomlinson
Copy link
Member

This is a great point, if the scheduler uses ws or ucx the controller wont be able to talk to it. Ideally, all communication would happen over the HTTP API but that isn't enabled by default right now.

Perhaps an annotation on the DaskCluster is the right way to handle setting the protocol for now?

@BitTheByte
Copy link
Author

Looks like I didn't provide much information, this issue is about scheduler <=> worker communication, I'd like my cluster to communicate over ws rather than the hardcoded tcp protocol since you also mentioned it, the operator would also need this information to be able to contact the scheduler, I'm thinking of something like

apiVersion: kubernetes.dask.org/v1
kind: DaskCluster
metadata:
  name: dask-f3a0c12f
  namespace: default
spec:
 protocol: "ws"
 scheduler:
  ....

@jacobtomlinson
Copy link
Member

Ah yep I see what you mean. I agree that extending the CRD to include a protocol field makes sense. We will need to handle #753 in order to do this.

@jacobtomlinson jacobtomlinson changed the title Support for WebSocket Protocol Support for other protocols Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants