Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeCluster Docs Typo #665

Closed
chriscardillo opened this issue Mar 4, 2023 · 2 comments · Fixed by #681
Closed

KubeCluster Docs Typo #665

chriscardillo opened this issue Mar 4, 2023 · 2 comments · Fixed by #681

Comments

@chriscardillo
Copy link

Describe the issue: Latest docs for using the KubeCluster class uses a name that is not a "a lowercase RFC 1123 subdomain", which cases a 403 error when ran in a Kubernetes cluster.

Minimal Complete Verifiable Example: Run the latest docs example:

from dask_kubernetes.operator import KubeCluster
cluster = KubeCluster(name="my_dask_cluster", image='ghcr.io/dask/dask:latest')

Anything else we need to know?: my-dask-cluster will work as an alternative.

Environment:

  • Dask version: dask==2023.3.0, dask-kubernetes==2023.1.1
  • Python version: 3.9.14
  • Operating System: Debian GNU/Linux 11 (bullseye)
  • Install method (conda, pip, source): pip
  • Kubernetes version: 1.25.3
@jacobtomlinson
Copy link
Member

jacobtomlinson commented Mar 7, 2023

Thanks for raising this. I see two issues here:

  • Our docs have an invalid name
  • We are not doing any input validation on the name

It would be good to address both of those problems.

@jacobtomlinson
Copy link
Member

Closed the immediate bug in #681 and opened #682 to track future work around input sanitising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants