Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an upcoming recommended lint #1680

Merged
merged 1 commit into from Mar 25, 2022
Merged

Fix an upcoming recommended lint #1680

merged 1 commit into from Mar 25, 2022

Conversation

natebosch
Copy link
Member

https://dart-lang.github.io/linter/lints/null_check_on_nullable_type_parameter.html

Eagerly fixing before we start picking up the new lint package.

@natebosch
Copy link
Member Author

Another option would be to switch from ! to as T. It doesn't matter much either way - this utility only lives here because it's annoying to move without copying it and it's only used in 2 places.

@natebosch natebosch merged commit 8e8150a into master Mar 25, 2022
@natebosch natebosch deleted the null-check-on-nullable branch March 25, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@natebosch @jakemac53